Use Slice.literal for fast_float when supported, part 2
#16261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
approved these changes
Oct 24, 2025
| LARGE_POWER_OF_5 = Slice[ | ||
| 1414648277510068013_u64, 9180637584431281687_u64, 4539964771860779200_u64, | ||
| 10482974169319127550_u64, 198276706040285095_u64, | ||
| {% if compare_versions(Crystal::VERSION, "1.16.0") < 0 %} |
There was a problem hiding this comment.
thought: The value lists are identical between both types. We could reduce code duplication by making only the outer layer conditional:
{% begin %}
{% if compare_versions(Crystal::VERSION, "1.16.0") < 0 %}
[
{% else %}
Slice(UInt64).literal(
{% end %}
1_u64,
# ...
7450580596923828125_u64,
{% if compare_versions(Crystal::VERSION, "1.16.0") < 0 %}
]
{% else %}
)
{% end %}
{% end %}The added overhead won't make this much appealing for very short slices. But it might be a good idea for the bigger ones? WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #15667.